cloudtools / troposphere

troposphere - Python library to create AWS CloudFormation descriptions
BSD 2-Clause "Simplified" License
4.93k stars 1.45k forks source link

Add ApiFunctionAuth serverless class for Api Function events #2145

Closed vvangestel closed 1 year ago

vvangestel commented 1 year ago

Api Function Auth follows a different structure from Api Auth and thus should not re-use the same class. Previously used https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-property-api-apiauth.html versus intended https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/sam-property-function-apifunctionauth.html.

This PR fixes this discrepancy. Fixes #2144

vvangestel commented 1 year ago

Hello, can this PR receive a set of :eyes:

Thanks :pray:

markpeek commented 1 year ago

Thank you for the PR and sorry about the delay. I added more logic via 2c7f04f for backward compatibility, deprecation warning, and tests.