search

cloudtools / troposphere

troposphere - Python library to create AWS CloudFormation descriptions
BSD 2-Clause "Simplified" License
4.93k stars 1.45k forks source link

Added tags to EventBridge (Events) Rule resource and fixed an error in CONTRIBUTING.md #2158

Closed lreeder-arpio closed 1 year ago

lreeder-arpio commented 1 year ago

Per https://docs.aws.amazon.com/eventbridge/latest/userguide/eb-tagging.html, only two EventBridge resources support tags: event buses and rules. The Troposphere EventBus resource had a field for tags, but Rules was missing it, probably because the Cloudformation Resource Specification was missing it. This is issue https://github.com/cloudtools/troposphere/issues/2151.

This PR adds a jsonpatch to plug Tags for the Events::Rules resource into the resource specification and adds Tags to the Rules class. Also, the example for running scripts/gen.py included the cloudformation spec file as an argument, which causes gen.py to treat it as a service name and build a corrupted file. This patch removes the cloudformation spec file from the example.

markpeek commented 1 year ago

Thanks!

markpeek commented 11 months ago

Needed to revert this commit since it is not implemented yet and causes rollbacks.

lreeder-arpio commented 11 months ago

Yeah, sorry. I missed that it wasn't supported in CloudFormation.