search

cloudtools / troposphere

troposphere - Python library to create AWS CloudFormation descriptions
BSD 2-Clause "Simplified" License
4.93k stars 1.45k forks source link

Fix LaunchTemplateData NetworkInterfaces argument type #2188

Closed pierretr closed 1 year ago

pierretr commented 1 year ago

LaunchTemplateData should expect a list of NetworkInterfaceProperty instead of a list of NetworkInterfaces as NetworkInterfaces argument.

markpeek commented 1 year ago

I don't believe this change is correct. AWS::EC2::LaunchTemplate LaunchTemplateData specifies a NetworkInterfaces property that is a list of AWS::EC2::LaunchTemplate NetworkInterface (changed to NetworkInterfaces in troposphere due to naming).

This is different than NetworkInterfaceProperty defined via AWS::EC2::Instance NetworkInterface which is used by Instance.

Can you give more information via an Issue on what isn't working for you?

pierretr commented 1 year ago

Thank you for you quick answer. I confused NetworkInterfaces with NetworkInterface in troposphere. And indeed NetworkInterface corresponds to the AWS::EC2::LaunchTemplate NetworkInterface property as expected. Sorry for the noise!