search

cloudtools / troposphere

troposphere - Python library to create AWS CloudFormation descriptions
BSD 2-Clause "Simplified" License
4.92k stars 1.45k forks source link

Elasticsearch instance type names have changed #2198

Closed NeilJed closed 8 months ago

NeilJed commented 8 months ago

AWS Comment here: https://docs.aws.amazon.com/opensearch-service/latest/developerguide/rename.html#rename-instances

Instance types in Amazon OpenSearch Service are now in the format <type>.<size>.search—for example, m6g.large.search rather than m6g.large.elasticsearch. You don't need to take any action. Existing domains will start automatically referring to the new instance types within the API and in the Billing and Cost Management console.

The list of new instance type names are here: https://docs.aws.amazon.com/opensearch-service/latest/developerguide/supported-instance-types.html

While the old names point to the new, would it be more "correct" to use the new names? Maybe in the first instance we can just add the new names to the list in the constants?

markpeek commented 8 months ago

@NeilJed can you comment/approve PR #2199? I did shorten the names by using a prefix of "SEARCH*" instead of "OPENSEARCH*".

I pulled the instance names from the aws cli so hopefully those are all correct.

NeilJed commented 8 months ago

Looks good to me.

markpeek commented 8 months ago

@NeilJed thank you for reviewing. I did make the sort order a little nicer and pushed it out in Release 4.5.1