search

cloudtrends / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
1 stars 1 forks source link

Invalid URL triggers DCHECK during navigation #104

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Launch a debug version of cefclient
2. Enter an invalid URL, e.g., http://^/ or http:///
3. Press enter to navigate to the invalid URL

What is the expected output? What do you see instead?

Expect to see the standard page load error.  Instead, this triggers a DCHECK in 
the debug build of libcef.dll.

What version of the product are you using? On what operating system?

CEF r82 on 32-bit Windows 7.

Please provide any additional information below.

Problem is in BrowserWebViewDelegate::decidePolicyForNavigation.  In 
particular, it seems that the following piece of code needs to verify that 
request_url.is_valid() before calling spec():

    GURL request_url = request.url();
    req->SetURL(UTF8ToWide(request_url.spec()));

Original issue reported on code.google.com by emerick on 29 Jul 2010 at 8:10

GoogleCodeExporter commented 9 years ago 
Fixed in revision 94.

Original comment by magreenb...@gmail.com on 9 Aug 2010 at 8:04