cloudtrends / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
1 stars 1 forks source link

Printing doesn't respect margins in print_settings.cc #112

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Print any page - 
2. see that the margins are not half a centimeter.

I changed the margins to be half a centimeter for the header and footer and one 
centimeter for left/right/top/bottom of the actual page. I also cleaned up some 
of the print page code. 

Attached is a code diff.

I am also planning on exposing the print margins (and a couple other printing 
options) outside of cef. Would this be best exposed in the handler?

Original issue reported on code.google.com by udam.sa...@gmail.com on 14 Aug 2010 at 2:24

Attachments:

GoogleCodeExporter commented 9 years ago
Updating diff to also expose print margins/paper type/ page orientation to a 
cef handler as well.

Original comment by udam.sa...@gmail.com on 16 Aug 2010 at 10:39

Attachments:

GoogleCodeExporter commented 9 years ago
This is more of an enhancement rather than a defect - especially so with the 
2nd set of diffs. 

Original comment by udam.sa...@gmail.com on 16 Aug 2010 at 10:40

GoogleCodeExporter commented 9 years ago
Thank you for the excellent patch. Committed as revision 98 with some minor 
style changes and a bug fix (check the return value from 
print_context_.NewDocument() to avoid an assert if you cancel the "Save As" 
dialog when printing to XPS Writer).

Original comment by magreenb...@gmail.com on 31 Aug 2010 at 3:22