search

cloudtrends / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
1 stars 1 forks source link

MENU_CAN_GO_FORWARD bit is always set in CefHandler::HandleBeforeMenu #114

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Break in ClientHandler::HandleBeforeMenu and observe menuInfo.editFlags.  
MENU_CAN_GO_FORWARD is always set

What is the expected output? What do you see instead?
MENU_CAN_GO_FORWARD should only be set if there is forward history

What version of the product are you using? On what operating system?
r94, Win XP

Please provide any additional information below.
Webkit added a new enum value to WebContextMenuData::EditFlags.  This value 
conflicted with the value chosen for Cef's MENU_CAN_GO_FORWARD.  I've attached 
a patch which assigns new values for Cef's menu capabilities which should avoid 
conflict in the future.  I also updated the default context menu handler to use 
Cef's enum values.  This usage maps more closely to what another consumer would 
do.

Original issue reported on code.google.com by mikeyk...@gmail.com on 25 Aug 2010 at 9:03

Attachments:

GoogleCodeExporter commented 9 years ago 
Thank you for the patch, committed with minor modifications as revision 99.

Original comment by magreenb...@gmail.com on 31 Aug 2010 at 3:34