search

cloudtrends / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
1 stars 1 forks source link

ParseDialogResultEx uses incorrect page range variables #179

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
ParseDialogResultEx in win_printing_context.cc sets page_ranges and 
num_page_ranges if the PD_PAGENUMS flag is set, but then it uses the range 
values in dialog_options (i.e., it completely ignores the variables it set).

The attached patch corrects this issue.

Original issue reported on code.google.com by emerick on 27 Jan 2011 at 6:20

Attachments:

GoogleCodeExporter commented 9 years ago 
Will dialog_options.lpPageRanges and dialog_options.nPageRanges be NULL/0 when 
the PD_PAGENUMS flag isn't set? Could we eliminate the page_ranges and 
num_page_ranges variables and get the same result?

Original comment by magreenb...@gmail.com on 27 Jan 2011 at 6:29

GoogleCodeExporter commented 9 years ago 
No, PD_PAGENUMS just indicates that the page range radio button should be 
selected by default.  It's valid to specify a non-NULL page range in 
dialog_options.lpPageRanges (it's an input/output variable) yet not specify 
PD_PAGENUMS.

Original comment by emerick on 27 Jan 2011 at 6:41

GoogleCodeExporter commented 9 years ago 
Thanks, fixed in revision 172.

Original comment by magreenb...@gmail.com on 27 Jan 2011 at 6:46