cloudtrends / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
1 stars 1 forks source link

Crash when closing cefclient with WebKit Inspector open #182

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Launch cefclient
2. Select "Tests > Show Developer Tools"
3. With the inspector window still open, close the cefclient window
4. Crash

What is the expected output? What do you see instead?

The crash happens in the processing of WM_DESTROY -- trying to get a HWND from 
a CefBrowserImpl that's already been deleted.  The top of the stack trace is:
    libcef.dll!CefBrowserImpl::UIT_GetMainWndHandle()
    libcef.dll!CefBrowserImpl::UIT_CloseBrowser()
    libcef.dll!CefBrowserImpl::UIT_DestroyBrowser()
    libcef.dll!CefBrowserImpl::WndProc()

What version of the product are you using? On what operating system?
r178, WinXP

Original issue reported on code.google.com by mikeyk...@gmail.com on 1 Feb 2011 at 2:12

GoogleCodeExporter commented 9 years ago
I have a potential fix for the issue.  

The call to 'browser->UIT_DestroyDevToolsClient();' caused 'client' to be 
deleted.  The subsequent call 'client->browser()->UIT_CloseBrowser();' led to a 
crash.  The attached patch gets the browser pointer before the object is deleted

Original comment by mikeyk...@gmail.com on 1 Feb 2011 at 2:31

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks, committed as revision 180.

Original comment by magreenb...@gmail.com on 1 Feb 2011 at 3:45