cloudtrends / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
1 stars 1 forks source link

isMainContent in handleLoadEnd seems inaccurate #183

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Enter http://nunzioweb.com/iframes-example.htm into the address bar
2. Observe values of isMainContent in handleLoadEnd
3. Click the "Reload" button
4. Observe values of isMainContent in handleLoadEnd
5. Re-enter http://nunzioweb.com/iframes-example.htm into the address bar
6. Observe values of isMainContent in handleLoadEnd

What is the expected output? What do you see instead?

The page has 3 iframes, so I would expect handleLoadEnd to be called 3 times 
with isMainContent==false and 1 time with isMainContent==true.  I would expect 
this to be consistent when reloading the page, either with the "Reload" button 
or by re-entering the URL.

In steps 2 and 4, handleLoadEnd is called 4 times with isMainContent==true.  In 
step 6, handleLoadEnd is called 4 times with isMainContent==false.

What version of the product are you using? On what operating system?
r178, WinXP

Original issue reported on code.google.com by mikeyk...@gmail.com on 1 Feb 2011 at 6:21

GoogleCodeExporter commented 9 years ago
Steps 2 and 4 are behaving as designed. |isMainContent| will be false only if 
the iframe loading occurs /after/ the main content has finished loading. If the 
iframe loading is occurring at the same time as the main content loading then 
|isMainContent| will be true and you can differentiate between the top-level 
frame and the iframes by checking whether the |frame| parameter is empty.

Step 6 appears to be a bug -- it should give the same results as steps 2 and 4.

Original comment by magreenb...@gmail.com on 1 Feb 2011 at 3:58

GoogleCodeExporter commented 9 years ago
Step 6 is fixed in revision 181.

Original comment by magreenb...@gmail.com on 1 Feb 2011 at 4:53

GoogleCodeExporter commented 9 years ago
Load notification usage has been further clarified in issue 200 and revision 
202.

Original comment by magreenb...@gmail.com on 8 Mar 2011 at 7:34