Closed GoogleCodeExporter closed 9 years ago
I have a patch that partially addresses this issue. I've moved logic from
didChangeLocationWithinPage to didNavigateWithinPage. This is more consistent
with the head revision of testshell. In fact, our signature of
didChangeLocationWithinPage didn't match the base's, so the code in question
was never being executed.
The outstanding issue is that CefClient's forward and back buttons don't
reflect the proper history since HandleLoadStart and HandleLoadEnd aren't
triggered in this codepath. Marshall, do you think it would be appropriate to
call the HandleLoad functions here, or should we choose a different strategy?
Original comment by mikeyk...@gmail.com
on 22 Mar 2011 at 4:44
Attachments:
Thanks for catching this, patch committed as revision 206.
HandleLoadStart/End shouldn't be called in this situation. I'll change
cefclient in the near future to use a different approach for updating the
button state. I've created issue #208 to track this.
Original comment by magreenb...@gmail.com
on 22 Mar 2011 at 11:57
Original issue reported on code.google.com by
mikeyk...@gmail.com
on 21 Mar 2011 at 10:49Attachments: