cloudtrends / chromiumembedded

Automatically exported from code.google.com/p/chromiumembedded
1 stars 1 forks source link

Set User Agent #95

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This patch allows setting and getting of the user agent

It is an enhancement 

Original issue reported on code.google.com by lodle...@gmail.com on 21 Jun 2010 at 6:39

Attachments:

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
There is a very small typo in this patch.
"topRightRet" should actually be "useragentRet".
There is nothing like topRightRet that the code should refer to.Correct me if I 
am wrong.

Original comment by pulkitru...@gmail.com on 30 Jul 2010 at 4:37

GoogleCodeExporter commented 9 years ago
There is another typo in the code : The file to be used is cef_context.cc 
instead of context.cc for the modifications described in the patch. 

Original comment by pulkitru...@gmail.com on 5 Aug 2010 at 10:54

GoogleCodeExporter commented 9 years ago
This patch wont work on the newest cef as its ment for an old version (81)

Original comment by lodle...@gmail.com on 5 Sep 2010 at 8:07

GoogleCodeExporter commented 9 years ago
but the typo was correct

Original comment by lodle...@gmail.com on 7 Sep 2010 at 1:23

GoogleCodeExporter commented 9 years ago
Changing the user agent after it's already been requested may result in 
unexpected behavior (see the comment in webkit/glue/webkit_glue.cc 
SetUserAgent). Would it be acceptable for your use case to set the user agent 
only when CEF is initialized?

Original comment by magreenb...@gmail.com on 16 Nov 2010 at 5:53

GoogleCodeExporter commented 9 years ago
yes, I have changed it and set it in the cef project itself where it sets the 
user agent for cef. I just append mine to the chrome one and it works for me.

Original comment by pulkitru...@gmail.com on 16 Nov 2010 at 7:16

GoogleCodeExporter commented 9 years ago
Wouldnt have an issue with that. I normally set it after init but before 
CreateBrowser

Original comment by lodle...@gmail.com on 17 Nov 2010 at 12:45

GoogleCodeExporter commented 9 years ago

Original comment by magreenb...@gmail.com on 18 Nov 2010 at 3:17