search

cloudveiltech / Filter-Windows

HTTP/S Content Filter for Windows 7 and newer
Mozilla Public License 2.0
9 stars 13 forks source link

Keep hash of DNS settings last applied by the app for the sake of cleanup #44

Open TechnikEmpire opened 7 years ago

TechnikEmpire commented 7 years ago

Keep a hash of the last DNS settings written by the app. When we read a config file and there's no DNS settings present, check the hash, see if the old settings are still applied to the NIC's, and if so, reset the DNS servers for affected NIC's back to DHCP instead of the old, now removed static IP's.

I would not worry about this posing a securing risk. Users tampering with this key would not enable any sort of tampering with actual filtering functionality, so long as we only use this key for cleanup and not for verification. Verification should remain as it is, the settings that should apply are held in memory by the app.

dkwiebe commented 6 years ago

@kfreezen and @montesound Do either of you know if this was taken care of? I know it was discussed and work was done on it.

kfreezen commented 6 years ago

This is not done.

On Dec 22, 2017 3:18 PM, "Darren Wiebe" notifications@github.com wrote:

@kfreezen https://github.com/kfreezen and @montesound https://github.com/montesound Do either of you know if this was taken care of? I know it was discussed and work was done on it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cloudveiltech/Citadel-Windows/issues/44#issuecomment-353689255, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVLLG-zf56XFDs9LJTLWJCU6NPpzb91ks5tDDjOgaJpZM4PE0Mg .