search

cloudviz / agentless-system-crawler

A tool to crawl systems like crawlers for the web
Apache License 2.0
117 stars 44 forks source link

Implement a ctprobe plugin using the more efficient conntrackprobe #303

Closed stefanberger closed 7 years ago

stefanberger commented 7 years ago

Implement a ctprobe plugin that is using the more efficient conntrackprobe fro detecting container traffic.

Signed-off-by: Stefan Berger stefanb@linux.vnet.ibm.com

stefanberger commented 7 years ago

For now I am interested in how the tests here end...

codecov-io commented 7 years ago

Codecov Report

Merging #303 into master will decrease coverage by 0.01%. The diff coverage is 88.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #303      +/-   ##
==========================================
- Coverage   88.96%   88.95%   -0.02%     
==========================================
  Files         114      115       +1     
  Lines        4351     4581     +230     
==========================================
+ Hits         3871     4075     +204     
- Misses        480      506      +26
Impacted Files Coverage Δ
...awler/plugins/systems/ctprobe_container_crawler.py 88.69% <88.69%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d8319c...4d11fcb. Read the comment docs.

sahilsuneja1 commented 7 years ago

Although you have great tests, codecov is unhappy coz it bring coverage down from 89 to 88% (see travis output as well). Only exception paths remain untested: https://codecov.io/gh/cloudviz/agentless-system-crawler/pull/303/diff

stefanberger commented 7 years ago

Should be close enough now ....

sahilsuneja1 commented 7 years ago

Indeed, awesome, thanks!