search

cloudviz / agentless-system-crawler

A tool to crawl systems like crawlers for the web
Apache License 2.0
117 stars 44 forks source link

Flake8 setup.py and tests too. #319

Closed cclauss closed 7 years ago

cclauss commented 7 years ago

Replaces #318

Start testing but allow failures on Python 3.

Signed-off-by: Chris Clauss cclauss@bluewin.ch

sahilsuneja1 commented 7 years ago

Thanks again @cclauss, but the problem now is that flake8 now complains, not for the crawler codebase, but for the secondary repo that the crawler brings in- psvmi. Fixing those should be beyond the crawler repo's responsibility.

sahilsuneja1 commented 7 years ago

Thanks @cclauss. I'll merge this (and the others) when I have some time to straightaway fix the flake8 errors that this change introduces on tests/*. Else the repo would be in failing state for a while :)

sahilsuneja1 commented 7 years ago

Actually, I'll just push my changes to your 'patch-7' branch, if that's okay.

cclauss commented 7 years ago

OK

sahilsuneja1 commented 7 years ago

Waiting on #323's comment