search

cloudviz / agentless-system-crawler

A tool to crawl systems like crawlers for the web
Apache License 2.0
116 stars 44 forks source link

12 out 344 tests fail #380

Open canturkisci opened 5 years ago

canturkisci commented 5 years ago

Description

sudo make test All tests do not pass in vanilla crawler. All failed tests seem to be related to the: tests.unit.test_dockercontainer.DockerDockerContainerTests

One suspicion: Can this be related to the missing dockerengine package in Issue #379 ?

How to Reproduce

sudo make test

Log Output

Way too much to post here. I can rep if need be.. Net is: All are related to DockerDockerContainerTests.*

Final Result: 12 failed, 332 passed in 755.95 seconds

sahilsuneja1 commented 5 years ago

I am recreating crawler env in a new Ubuntu1804 VM, will try to address all recent issues.

sahilsuneja1 commented 5 years ago

@canturkisci I would need to do a screenshare session with you on this.

canturkisci commented 5 years ago

Ok. I can try to close on #379 and then revisit this. My suspicion is, the missing steps there can be triggering this. here. as they are all http/docker related.

sahilsuneja1 commented 5 years ago

Ok, but I think make test would still not work coz of docker-in-docker issues: http://jpetazzo.github.io/2015/09/03/do-not-use-docker-in-docker-for-ci/ I could not get it to work, lemme know if you have any success. If your host/VM setup is ready, see if make unit and make functional works for you. We might need to edit make test to do these instead.

canturkisci commented 5 years ago

@sahilsuneja1 I tried both of these:

sudo make unit
sudo make functional

They fail with the same message:

setup.py: error: unrecognized arguments: --cov=.
  inifile: None
  rootdir: /home/ubuntu/agentless-system-crawler
Makefile:53: recipe for target 'functional' failed
make: *** [functional] Error 4
sahilsuneja1 commented 5 years ago

Oh ok, they need an additional step coz they are host-based: pip install codecov pytest-cov==2.3.0 pytest==2.9.2