search

cloudviz / agentless-system-crawler

A tool to crawl systems like crawlers for the web
Apache License 2.0
116 stars 44 forks source link

Adding sles support for agentless-crawler #385

Closed Basavaraju-G closed 5 years ago

sahilsuneja1 commented 5 years ago

Thanks @Basavaraju013 ! Could you please add some test cases to go with this change? This should help you: https://github.com/cloudviz/agentless-system-crawler/blob/master/tests/unit/test_osinfo.py

Also, please fix some code style issues which causes Travis to fail:

1.50s$ flake8 --count --max-complexity=10 --statistics crawler
crawler/utils/osinfo.py:15:1: E302 expected 2 blank lines, found 1
crawler/utils/osinfo.py:50:1: E302 expected 2 blank lines, found 1
crawler/utils/osinfo.py:59:25: E222 multiple spaces after operator
crawler/utils/osinfo.py:66:1: E302 expected 2 blank lines, found 1
crawler/utils/osinfo.py:75:1: E302 expected 2 blank lines, found 1
crawler/utils/package_utils.py:244:71: E231 missing whitespace after ','
1       E222 multiple spaces after operator
1       E231 missing whitespace after ','
4       E302 expected 2 blank lines, found 1
6
The command "flake8 --count --max-complexity=10 --statistics crawler" exited with 1.
Basavaraju-G commented 5 years ago

@sahilsuneja1 @tatsuhirochiba suggested changes are made. please reivew the patch.

tatsuhirochiba commented 5 years ago

@sahilsuneja1 Could you also review and merge it if it looks good? Since I do not have write access to the repo, I cannot merge it actually..