search

cloudwan / gohan

Gohan is an API Gateway Server written by Go that makes it easy for developers to create and maintain REST-style API
http://www.slideshare.net/natiueno/gohan-61170476
Other
109 stars 44 forks source link

Remove vendored golang.org/x/net/trace #692

Closed zimnx closed 6 years ago

zimnx commented 6 years ago

This package is not used by Gohan. Vendoring it causes that extensions that imports gprc package panics on startup because of https://github.com/etcd-io/etcd/issues/9357

~/work/src/github.com/cloudwan/gohan on  remove-x-net-trace-from-vendor ⌚ 15:12:18         
$ git grep "net/trace"                                                                       
vendor/github.com/coreos/etcd/embed/serve.go:   "golang.org/x/net/trace"                     
vendor/github.com/coreos/etcd/etcdserver/api/v3client/v3client.go:// (e.g., x/net/trace), causing ctx.String() to throw data races.                                                       
vendor/google.golang.org/grpc/clientconn.go:    "golang.org/x/net/trace"                     
vendor/google.golang.org/grpc/server.go:        "golang.org/x/net/trace"                     
vendor/google.golang.org/grpc/stream.go:        "golang.org/x/net/trace"                     
vendor/google.golang.org/grpc/trace.go: "golang.org/x/net/trace"                             
vendor/google.golang.org/grpc/trace.go:// EnableTracing controls whether to trace RPCs using the golang.org/x/net/trace package.