[CW-1065][BL-355] fix sync watcher races - Githubissues

cloudwan / gohan

Gohan is an API Gateway Server written by Go that makes it easy for developers to create and maintain REST-style API

http://www.slideshare.net/natiueno/gohan-61170476

Other

109 stars 44 forks source link

[CW-1065][BL-355] fix sync watcher races #725

Closed p-kozlowski closed 5 years ago

p-kozlowski commented 5 years ago

Reviewers, this PR is going to be large. I'd like to ask you for a quick review of smaller functional parts already.

p-kozlowski commented 5 years ago

Reviewers, this code is ready for a review. One thing I noted is missing is handling of ETCD compaction. It's not directly in the scope of this PR, nevertheless I'll add it here tomorrow.

p-kozlowski commented 5 years ago

Compaction issues resolved. Code is ready for review. Before merging, I'll give it a round of testing - I'll post results here once I'm done.

p-kozlowski commented 5 years ago

end-to-end testing done, works fine. reviewers, gentle reminder about this PR

p-kozlowski commented 5 years ago

@zimnx @cierpuchaw I've addressed your comment, please re-review.