search

cloudy-astrophysics / bug-tracker-migration-test

Trial run for importing the nublado.org Trac tickets as GitHub issues
0 stars 0 forks source link

retain case sensitivity when reading emission line labels within input stream? (trac #207) #209

Open cloudy-bot opened 13 years ago

cloudy-bot commented 13 years ago

reported by: @CloudyLex

the attached sim behaves differently in c08 vs c10 and trunk. C08 respected the case that was specified in the line following the "punch line emissivity" command while c10 and later change case to caps.

run caps.in and compare the line labels in the header in caps.emis with the labels specified in caps.in

parsing occurs at save_line.cpp:77. apparently c_str returns CAP'D version of input??

Migrated from https://www.nublado.org/ticket/207

{
    "status": "new",
    "changetime": "2019-02-04T13:07:06Z",
    "_ts": "1549285626580696",
    "description": "the attached sim behaves differently in c08 vs c10 and trunk.  C08 respected the case that was specified in the line following the \"punch line emissivity\" command while c10 and later change case to caps.\n\nrun caps.in and compare the line labels in the header in caps.emis with the labels specified in caps.in\n\nparsing occurs at save_line.cpp:77.  apparently c_str returns CAP'D version of input?? ",
    "reporter": "gary",
    "cc": "",
    "resolution": "",
    "time": "2011-06-26T13:24:03Z",
    "component": "input parser",
    "summary": "retain case sensitivity when reading emission line labels within input stream?",
    "priority": "major",
    "keywords": "",
    "version": "trunk",
    "milestone": "no milestone",
    "owner": "nobody",
    "type": "enhancement"
}
cloudy-bot commented 13 years ago

Attachment: caps.in

cloudy-bot commented 13 years ago

@rjrw commented:

The example given is internally inconsistent:

punch last lines emissivity ".emis"
H  1  4861
He 1  3820
AR 3  5192
end of lines
  • in one case the chemical symbol is given, in the other a capitalized form of it.
cloudy-bot commented 13 years ago

@rjrw commented:

r5217 (on trunk) now parses both cases with Parser::getLineID to ensure consistency.

cloudy-bot commented 13 years ago

Removing stale milestone.

cloudy-bot commented 13 years ago

@peter-van-hoof-noaccount changed milestone from "" to "no milestone"