cloudy-astrophysics / bug-tracker-migration-test

Trial run for importing the nublado.org Trac tickets as GitHub issues
0 stars 0 forks source link

undestand strange distinction between large / small H2 in secondary rate (trac #243) #245

Open cloudy-bot opened 11 years ago

cloudy-bot commented 11 years ago

reported by: @CloudyLex

understand following at mole_reactions.cpp:1350

if( h2.lgEnabled && h2.lgEvaluated && hmi.lgH2_Chemistry_BigH2 )
{
    return secondaries.x12tot*10.;
}
else
{
    return secondaries.x12tot*3.;
}

Migrated from https://www.nublado.org/ticket/243

{
    "status": "new",
    "changetime": "2019-02-04T13:22:59Z",
    "_ts": "1549286579464878",
    "description": "understand following at mole_reactions.cpp:1350\n\n{{{\nif( h2.lgEnabled && h2.lgEvaluated && hmi.lgH2_Chemistry_BigH2 )\n{\n\treturn secondaries.x12tot*10.;\n}\nelse\n{\n\treturn secondaries.x12tot*3.;\n}\n\n}}}",
    "reporter": "gary",
    "cc": "",
    "resolution": "",
    "time": "2012-11-08T14:26:38Z",
    "component": "chemical network",
    "summary": "undestand strange distinction between large / small H2 in secondary rate",
    "priority": "major",
    "keywords": "",
    "version": "trunk",
    "milestone": "c19 branch",
    "owner": "nobody",
    "type": "physics"
}
cloudy-bot commented 11 years ago

@CloudyLex commented:

this affects cosmic ray excitation/dissociation??

should examine CR dominated model to see what effect this has on results.

cloudy-bot commented 11 years ago

@CloudyLex changed description from:

understand following at molre_reactions.cpp:1350

if( h2.lgEnabled && h2.lgEvaluated && hmi.lgH2_Chemistry_BigH2 )
{
  return secondaries.x12tot*10.;
}
else
{
  return secondaries.x12tot*3.;
}

to:

understand following at mole_reactions.cpp:1350

if( h2.lgEnabled && h2.lgEvaluated && hmi.lgH2_Chemistry_BigH2 )
{
  return secondaries.x12tot*10.;
}
else
{
  return secondaries.x12tot*3.;
}
cloudy-bot commented 11 years ago

@CloudyLex commented:

The last change here was in r4748. Log message:

"branches/newmole/source - tripletdissoc variables unnecessary; kill them"

Before that it looked like this:

if( h2.lgH2ON  && h2.lgEvaluated && hmi.lgH2_Chemistry_BigH2 )
{
  return h2.tripletdissoc_H2g;
}
else
{
  return secondaries.x12tot*3.;
}

That code was added in r858, log message:

"Move further molecular reactions from H network to C network treatment."

reference: Millar, T.J., et.al, 1997,A&AS, 121, 139

Peter.
cloudy-bot commented 11 years ago

@peter-van-hoof-noaccount changed milestone from "h2star reintegration" to "c19 branch"