Snu = constant for Lya pump of H I 21 cm line is wrong (trac #392)

cloudy-astrophysics / bug-tracker-migration-test

Trial run for importing the nublado.org Trac tickets as GitHub issues

0 stars 0 forks source link

Snu = constant for Lya pump of H I 21 cm line is wrong (trac #392) #394

Closed cloudy-bot closed 4 years ago

cloudy-bot commented 6 years ago

reported by: @CloudyLex

The fix will be simple - need to remember source function and keep it constant at the two frequencies of the Lya pump.

atom_hyperfine.cpp:113

Migrated from https://www.nublado.org/ticket/392

{
    "status": "closed",
    "changetime": "2019-06-07T19:18:34Z",
    "_ts": "1559935114507868",
    "description": "The fix will be simple - need to remember source function and keep it constant at the two frequencies of the Lya pump.\n\natom_hyperfine.cpp:113",
    "reporter": "gary",
    "cc": "",
    "resolution": "fixed",
    "time": "2017-07-10T16:00:04Z",
    "component": "etc",
    "summary": "Snu = constant for Lya pump of H I 21 cm line is wrong",
    "priority": "major",
    "keywords": "",
    "version": "trunk",
    "milestone": "c17.02",
    "owner": "rjrw",
    "type": "defect - wrong answer"
}

cloudy-bot commented 6 years ago

@CloudyLex commented:

Milestone renamed

@CloudyLex changed milestone from "c17.01 release" to "C17.01 release"

cloudy-bot commented 6 years ago

@CloudyLex commented:

Milestone renamed

@CloudyLex changed milestone from "C17.01 release" to "C17.01"

cloudy-bot commented 6 years ago

@CloudyLex changed description from:

The fix will be simple - need to remember source function and keep it constant at the two frequencies of the Lya pump.

atom_hyperfine.cpp:113

to:

The fix will be simple - need to remember source function and keep it constant at the two frequencies of the Lya pump.

atom_hyperfine.cpp:113

@CloudyLex changed milestone from "C17.01" to "C17.02"

cloudy-bot commented 6 years ago

@peter-van-hoof-noaccount commented:

Milestone renamed

@peter-van-hoof-noaccount changed milestone from "C17.02" to "c17.02"

cloudy-bot commented 6 years ago

@rjrw commented:

For reference, this code was implemented at r11399

cloudy-bot commented 6 years ago

@rjrw commented:

The "set lya 21cm" command does not appear to be exercised in the test suite.

cloudy-bot commented 6 years ago

@peter-van-hoof-noaccount changed owner from "gary" to "rjrw"
@peter-van-hoof-noaccount changed status from "new" to "assigned"
@peter-van-hoof-noaccount changed summary from "Snu = constant for Lya pump of Lya is wrong" to "Snu = constant for Lya pump of H I 21 cm line is wrong"

cloudy-bot commented 6 years ago

@mchatzikos commented:

The code has been refactored at r12762 to treat the 'set lya 21cm constant' command separately from the other (excitation, kinetic) cases. In the constant case, the photon occupation numbers are adjusted by the ratio of relevant frequencies in the 3rd power.

Switching to using a CONSTANT source function by default and running the test suite with and without the patch led to very small differences in the 21cm line temperatures.

cloudy-bot commented 6 years ago

@mchatzikos commented:

r12763 implements the 'monitor 21cm temperature' command. These are employed by the three sims introduced at r12764, which are based on the sims that made it into Shaw, Ferland, & Hubeny 2017, ApJ, 843, 149, see fig. 10 therein. These sims exercise the 'set lya 21cm' with each of its three options: CONSTANT, KINETIC, and EXCITATION, which were hitherto not exercised in the test suite. A difference may be seen in the spin temperature among these three sims.

cloudy-bot commented 6 years ago

@mchatzikos commented:

Closing ticket as fixed.

@mchatzikos changed resolution from "" to "fixed"
@mchatzikos changed status from "assigned" to "closed"