cloudy-astrophysics / bug-tracker-migration-test

Trial run for importing the nublado.org Trac tickets as GitHub issues
0 stars 0 forks source link

Blnd equivalents of 6lev lines in c13 are missing (trac #393) #395

Closed cloudy-bot closed 4 years ago

cloudy-bot commented 6 years ago

reported by: peter

In c17 the 6lev lines were removed. We also made sure that enough levels were included in the stout O I model to capture the Ly beta fluorescence. However, currently this mechanism is broken (see #78).

The 6lev lines gave predictions for full multiplets, while stout resolves all the multiplets into individual lines. For backward compatibility we should add Blnd entries for multiplets that correspond to the old 6lev entries in c13.

Migrated from https://www.nublado.org/ticket/393

{
    "status": "closed",
    "changetime": "2019-02-04T12:09:37Z",
    "_ts": "1549282177514312",
    "description": "In c17 the 6lev lines were removed. We also made sure that enough levels were included in the stout O I model to capture the Ly beta fluorescence. However, currently this mechanism is broken (see #78).\n\nThe 6lev lines gave predictions for full multiplets, while stout resolves all the multiplets into individual lines. For backward compatibility we should add Blnd entries for multiplets that correspond to the old 6lev entries in c13.",
    "reporter": "peter",
    "cc": "",
    "resolution": "fixed",
    "time": "2017-07-12T15:58:29Z",
    "component": "atomic/molecular data base",
    "summary": "Blnd equivalents of 6lev lines in c13 are missing",
    "priority": "minor",
    "keywords": "",
    "version": "trunk",
    "milestone": "c17.01",
    "owner": "nobody",
    "type": "defect - etc"
}
cloudy-bot commented 6 years ago

proposed patch Attachment: patch_o1

cloudy-bot commented 6 years ago

@peter-van-hoof-noaccount commented:

It turns out that c17 uses enough levels to capture Ly beta pumping in O I, but not enough to fully recover the old 6lev model atom. For the latter 29 levels are needed. Also the way the number of levels was set was messy as it (mis-) used the variable atmdat.nDefaultPhotoLevelsFe for that. It is better to set the number of levels directly in the stout masterfile.

The attached proposed patch fixes all issues that are discussed here, except ticket #78.

cloudy-bot commented 6 years ago

Fixed with r11730 and r11731 on the trunk, and r11732 on c17_branch.

cloudy-bot commented 6 years ago

Milestone renamed

cloudy-bot commented 6 years ago

Milestone renamed

cloudy-bot commented 6 years ago

Milestone renamed