search

cloudy-astrophysics / bug-tracker-migration-test

Trial run for importing the nublado.org Trac tickets as GitHub issues
0 stars 0 forks source link

Blnd lines do not have emissivity (trac #415) #417

Closed cloudy-bot closed 4 years ago

cloudy-bot commented 6 years ago

reported by: @CloudyLex

Blends do not save the emissivity although we do report it. In sim tsuite/auto/orion_hii_open.in we include Blnd 5199A in the list of lines requested in the save line emissivity command but all entries are zero.

Migrated from https://www.nublado.org/ticket/415

{
    "status": "closed",
    "changetime": "2019-03-12T13:00:01Z",
    "_ts": "1552395601885397",
    "description": "Blends do not save the emissivity although we do report it.  In sim {{{tsuite/auto/orion_hii_open.in}}} we include {{{Blnd  5199A}}} in the list of lines requested in the {{{save line emissivity}}} command but all entries are zero.",
    "reporter": "gary",
    "cc": "",
    "resolution": "fixed",
    "time": "2018-04-18T11:53:29Z",
    "component": "infrastructure",
    "summary": "Blnd lines do not have emissivity",
    "priority": "major",
    "keywords": "",
    "version": "trunk",
    "milestone": "c19 branch",
    "owner": "nobody",
    "type": "defect - wrong answer"
}
cloudy-bot commented 6 years ago

Milestone renamed

cloudy-bot commented 6 years ago

@peter-van-hoof-noaccount commented:

The description is not correct, as can be easily seen by removing the keyword "emergent" from the save command. Saving the emissivity is supported for blends, but with the restriction shown here: source:trunk/source/lines.h@12600#L251.

Blnd 5199 has 5 components: "N 1" 5197.90, "N 1" 5200.26, "N 1R" 5199, "N 1C" 5199, "N 1T" 5199. The last two of those are of type 'r' and trigger the test above. See source:trunk/source/prt_lines.cpp@12600#L1103.

So returning 0 is clearly by design and not an oversight.

cloudy-bot commented 6 years ago

To fix this bug, we decided to remove all components from blends that are calculated with ad-hoc theory, such as the recombination contribution to these blends. Blends now only contain database lines as components. Blends that have no valid components left after this operation have been removed. These are: || Inwd 1549 || || Inwd 1240 || || Inwd 1035 || || Blnd 4341 || || Blnd 3736 || || Blnd 5592 || Blends that only have one components left have also been removed. The table below shows the line they should be replaced with || Blnd 977 || C 3 977.020 || Blnd 5755 || N 2 5754.61 || Blnd 765 || N 4 765.147 || Blnd 3726 || O 2 3726.03 || Blnd 3729 || O 2 3728.81 || Blnd 4363 || O 3 4363.21 || Blnd 630 || O 5 629.732 Two blends have been fixed. They only contained one component rather than the entire multiplet. These are || Blnd 1657 || C 1 1656.27 - 1658.12 (6 lines) || || Blnd 6580 || C 2 6578.05 + 6582.88 (2 lines) ||

As a result of these changes, blends only contain components of type 't' which are associated to a database transition. This condition is now enforced by addComponent() to prevent a regression. This also fixes various other potential problems related to blends, which are of a similar nature to the one reported here (i.e. quietly ignoring error conditions rather than reporting them).

In !PrtComment() a test has been removed that checked the amount of non-collisional excitation to Blnd 4363. This test is now moot as O 3 4363.21 by definition is only collisionally excited.

These changes are quite invasive, requiring quite a few alterations by users, so it is not appropriate to merge these to c17_branch. Hence the milestone has been changed to c19_branch.

The fix has been committed to the trunk in r12623.

to:

1552394079884380

To fix this bug, we decided to remove all components from blends that are calculated with ad-hoc theory, such as the recombination contribution to these blends. Blends now only contain database lines as components. Blends that have no valid components left after this operation have been removed. These are: || Inwd 1549 || || Inwd 1240 || || Inwd 1035 || || Blnd 4341 || || Blnd 3736 || || Blnd 5592 || Blends that only have one components left have also been removed. The table below shows the line they should be replaced with || Blnd 977 || C 3 977.020 || Blnd 5755 || N 2 5754.61 || Blnd 765 || N 4 765.147 || Blnd 3726 || O 2 3726.03 || Blnd 3729 || O 2 3728.81 || Blnd 4363 || O 3 4363.21 || Blnd 630 || O 5 629.732

As a result of these changes, blends only contain components of type 't' which are associated to a database transition. This condition is now enforced by addComponent() to prevent a regression. This also fixes various other potential problems related to blends, which are of a similar nature to the one reported here (i.e. quietly ignoring error conditions rather than reporting them).

In !PrtComment() a test has been removed that checked the amount of non-collisional excitation to Blnd 4363. This test is now moot as O 3 4363.21 by definition is only collisionally excited.

These changes are quite invasive, requiring quite a few alterations by users, so it is not appropriate to merge these to c17_branch. Hence the milestone has been changed to c19_branch.

The fix has been committed to the trunk in r12623.

to:

1552395296797632

To fix this bug, we decided to remove all components from blends that are calculated with ad-hoc theory, such as the recombination contribution to these blends. Blends now only contain database lines as components. Blends that have no valid components left after this operation have been removed. These are: || Inwd 1549 || || Inwd 1240 || || Inwd 1035 || || Blnd 4341 || || Blnd 3736 || || Blnd 5592 || Blends that only have one components left have also been removed. The table below shows the line they should be replaced with || Blnd 977 || C 3 977.020 || Blnd 5755 || N 2 5754.61 || Blnd 765 || N 4 765.147 || Blnd 3726 || O 2 3726.03 || Blnd 3729 || O 2 3728.81 || Blnd 4363 || O 3 4363.21 || Blnd 630 || O 5 629.732 Two blends have been fixed. They only contained one component rather than the entire multiplet. These are || Blnd 1657 || C 1 1656.27 - 1658.12 (6 lines) || || Blnd 6580 || C 2 6578.05 + 6582.88 (2 lines) ||

As a result of these changes, blends only contain components of type 't' which are associated to a database transition. This condition is now enforced by addComponent() to prevent a regression. This also fixes various other potential problems related to blends, which are of a similar nature to the one reported here (i.e. quietly ignoring error conditions rather than reporting them).

In !PrtComment() a test has been removed that checked the amount of non-collisional excitation to Blnd 4363. This test is now moot as O 3 4363.21 by definition is only collisionally excited.

These changes are quite invasive, requiring quite a few alterations by users, so it is not appropriate to merge these to c17_branch. Hence the milestone has been changed to c19_branch.

The fix has been committed to the trunk in r12623.

cloudy-bot commented 6 years ago

@peter-van-hoof-noaccount commented:

The following remaining blends had components removed: ||= blend =||= removed components =|| || Blnd 1657 || C 1R 1656 || || Blnd 9850 || C 1R 9850 || || Blnd 2326 || C 2H 2326 || || Blnd 1335 || C 2R 1335 || || Blnd 6580 || C 2R 6580, C 2P 6580 || || Blnd 1909 || C 3R 1909, C 3H 1909 || || Blnd 1176 || C 3R 1175 || || Blnd 1549 || C 4R 1549 || || Blnd 5199 || N 1R 5199, N 1C 5199, N 1T 5199 || || Blnd 1085 || N 2R 1085 || || Blnd 990 || N 3R 990 || || Blnd 2471 || O 2R 2471 || || Blnd 3727 || O 2R 3726, O 2R 3729, O 2H 3727 || || Blnd 7323 || O 2R 7323 || || Blnd 7332 || O 2R 7332 || || Blnd 7325 || O 2R 7323, O 2R 7332 || || Blnd 1666 || O 3H 1665, O 3A 1665 || || Blnd 835 || O 3R 835 || || Blnd 1402 || O 4H 1401 || || Blnd 789 || O 4R 789 ||

cloudy-bot commented 6 years ago

@peter-van-hoof-noaccount commented:

A partial merge of r12623 to c17_branch has been done in r12655. Here the missing components to Blnd 1657 and 6580 were added in preparation for the c17.02 release.