Is escape probability for He-like Ly alpha lines correct? (trac #79)

[cloudy-bot]

reported by: peter

The escape probability for He-like Ly alpha lines is multiplied by a factor opac.!ExpmTau[]. This factor is applied only to He-like Ly alpha lines, no other lines. Is this treatment correct? Is it correct that only He-like Ly alpha lines are treated this way? The multiplication factor is calculated at source:trunk/source/rt_line_all.cpp@2449#L156 and multiplied in on lines 293, 318, 339, 365 of source:trunk/source/rt_line_one.cpp@2449. On c08_branch the multiplication is done at source:branches/c08_branch/source/rt_line_all.cpp@2449#L181. Two fixit() statements have been added at source:trunk/source/rt_line_all.cpp@2449#L151 and source:trunk/source/rt_line_one.cpp@2449#L225.

Migrated from https://www.nublado.org/ticket/79

{
    "status": "closed",
    "changetime": "2009-07-05T16:09:50Z",
    "_ts": "1246810190000000",
    "description": "The escape probability for He-like Ly alpha lines is multiplied by a factor opac.!ExpmTau[]. This factor is applied only to He-like Ly alpha lines, no other lines. Is this treatment correct? Is it correct that only He-like Ly alpha lines are treated this way? The multiplication factor is calculated at source:trunk/source/rt_line_all.cpp@2449#L156 and multiplied in on lines 293, 318, 339, 365 of source:trunk/source/rt_line_one.cpp@2449. On c08_branch the multiplication is done at source:branches/c08_branch/source/rt_line_all.cpp@2449#L181. Two fixit() statements have been added at source:trunk/source/rt_line_all.cpp@2449#L151 and source:trunk/source/rt_line_one.cpp@2449#L225.",
    "reporter": "peter",
    "cc": "",
    "resolution": "fixed",
    "time": "2008-11-10T13:42:28Z",
    "component": "radiative transfer",
    "summary": "Is escape probability for He-like Ly alpha lines correct?",
    "priority": "major",
    "keywords": "",
    "version": "",
    "milestone": "",
    "owner": "nobody",
    "type": "physics"
}

[cloudy-bot]

• @rjrw commented:

Change pointers to source to TracLinks.

• @rjrw changed description from "The escape probability for He-like Ly alpha lines is multiplied by a factor opac.!ExpmTau[]. This factor is applied only to He-like Ly alpha lines, no other lines. Is this treatment correct? Is it correct that only He-like Ly alpha lines are treated this way? The multiplication factor is calculated on line 156 of rt_line_all.cpp (trunk at r2449) and multiplied in on lines 293, 318, 339, 365 of rt_line_one.cpp (trunk at r2449). On c08_branch the multiplication is done on line 181 of rt_line_all.cpp (c08_branch at r2449). Two fixit() statements have been added on line 151 of rt_line_all.cpp and line 225 of rt_line_one.cpp (trunk at r2449)." to "The escape probability for He-like Ly alpha lines is multiplied by a factor opac.!ExpmTau[]. This factor is applied only to He-like Ly alpha lines, no other lines. Is this treatment correct? Is it correct that only He-like Ly alpha lines are treated this way? The multiplication factor is calculated on line 156 of source:trunk/source/rt_line_all.cpp@2449 and multiplied in on lines 293, 318, 339, 365 of source:trunk/source/rt_line_one.cpp@2449. On c08_branch the multiplication is done on line 181 of source:branches/c08_branch/source/rt_line_all.cpp@2449. Two fixit() statements have been added on line 151 of source:trunk/source/rt_line_all.cpp@2449 and line 225 of source:trunk/source/rt_line_one.cpp@2449."

[cloudy-bot]

• @rjrw commented:

Include line references in links.

• @rjrw changed description from "The escape probability for He-like Ly alpha lines is multiplied by a factor opac.!ExpmTau[]. This factor is applied only to He-like Ly alpha lines, no other lines. Is this treatment correct? Is it correct that only He-like Ly alpha lines are treated this way? The multiplication factor is calculated on line 156 of source:trunk/source/rt_line_all.cpp@2449 and multiplied in on lines 293, 318, 339, 365 of source:trunk/source/rt_line_one.cpp@2449. On c08_branch the multiplication is done on line 181 of source:branches/c08_branch/source/rt_line_all.cpp@2449. Two fixit() statements have been added on line 151 of source:trunk/source/rt_line_all.cpp@2449 and line 225 of source:trunk/source/rt_line_one.cpp@2449." to "The escape probability for He-like Ly alpha lines is multiplied by a factor opac.!ExpmTau[]. This factor is applied only to He-like Ly alpha lines, no other lines. Is this treatment correct? Is it correct that only He-like Ly alpha lines are treated this way? The multiplication factor is calculated at source:trunk/source/rt_line_all.cpp@2449#L156 and multiplied in on lines 293, 318, 339, 365 of source:trunk/source/rt_line_one.cpp@2449. On c08_branch the multiplication is done at source:branches/c08_branch/source/rt_line_all.cpp@2449#L181. Two fixit() statements have been added at source:trunk/source/rt_line_all.cpp@2449#L151 and source:trunk/source/rt_line_one.cpp@2449#L225."

[cloudy-bot]

• @rporter commented:

Removed the mentioned factor. He-like lines are no longer pathological in this respect.

• @rporter changed resolution from "" to "fixed"
• @rporter changed status from "new" to "closed"

[cloudy-bot]

• @ commented:

Milestone C09 deleted

• @ changed milestone from "C09" to ""