search

cloudymax / pxeless

An automated system install and image customization tool for when PXE is not an option, or is not an option yet.
MIT License
112 stars 16 forks source link

switch combinations #9

Closed rit001 closed 2 years ago

rit001 commented 2 years ago

I hope you don't mind me raising issues like this as I don't have the time or really the skills to do direct modifications and pull requests.

Your script has a problem when trying to use the -s (source) switch as you also need to define the -n (code-name) switch as the script still tries to run function latest_release which will fail on the first curl as it can not retrieve a valid file without a code name being provided.

cloudymax commented 2 years ago

No worries, I appreciate you taking the time to report bugs.`

I was able to re-create the issue and will push a fix as soon as I'm able.

cloudymax commented 2 years ago

Looks like I'm able to get the desired behavior by making changes to the way I detect if an images is legacy(isolinux) vs el torito. Instead of doing a greater/less comparison on the release number, i'll just check fore the presence of isolinux in the extracted iso itself, and if its there, it's marked as legacy. This seems to let everything build properly.