disassociate_ip not implemented correctly?

cloudyr / aws.ec2

AWS EC2 Client Package

45 stars 28 forks source link

disassociate_ip not implemented correctly? #26

Closed itissid closed 6 years ago

itissid commented 7 years ago

It seems that the above API requires an AllocationIP based on the DisassociateAddress API doc request instead of allocation id. See this tentative PR for the changes I have made since to correct this.

itissid commented 7 years ago

PS: Ignore the changes to allocate_ip in that PR. they are related to the other issue I opened today

leeper commented 6 years ago

This works as currently implemented. I think the API docs are incorrect; I've submitted a suggested correction to them.