itissid commented 7 years ago

Issue: In the previous code the allocation_id was not returned for an EIP allocated in VPC when calling allocate_ip which caused release_ip to fail.

Fix: Based on the documentation for v2015-10-01, attribute domain should be used to distinguish VPC vs standard instead of publicIp.

Testing: My AWS account supports only VPC and not EC2 Classic, which is how I discovered the issue and tested the fix.

Lingering Concerns: I have not tested this with EC2 classic, I don't know how to do that. But someone should..

codecov-io commented 7 years ago

Codecov Report

Merging #27 into master will not change coverage. The diff coverage is 0%.

@@          Coverage Diff          @@
##           master    #27   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          21     21           
  Lines        1233   1236    +3     
=====================================
- Misses       1233   1236    +3

Impacted Files	Coverage Δ
R/ip.R	`0% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e0c158...3f115c8. Read the comment docs.

leeper commented 6 years ago

Thanks. I tweaked this slightly, but appreciate the PR.

cloudyr / aws.ec2

Update allocate_ip to return allocation_id #27

Codecov Report