cloudyr / aws.polly

Client for AWS Polly
https://cloud.r-project.org/package=aws.polly
23 stars 6 forks source link

Added option for NULL for languages to see all #6

Closed muschellij2 closed 4 years ago

muschellij2 commented 5 years ago

Please ensure the following before submitting a PR:

This fixes #5 for listing all voices.

muschellij2 commented 5 years ago

Does this seem to work on your end?

muschellij2 commented 5 years ago

So I think this works but I'm not sure @cloudyr or @leeper is still maintaining...

muschellij2 commented 4 years ago

This should now work. Good to see @antoine-sachet maintaining!

codecov-io commented 4 years ago

Codecov Report

Merging #6 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@         Coverage Diff         @@
##           master   #6   +/-   ##
===================================
  Coverage       0%   0%           
===================================
  Files           4    4           
  Lines          87   89    +2     
===================================
- Misses         87   89    +2
Impacted Files Coverage Δ
R/list_voices.R 0% <0%> (ø) :arrow_up:
R/synthesize.R 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c11b9c9...bc37302. Read the comment docs.

antoine-sachet commented 4 years ago

Thanks! Looks good to me, I'll start merging. In the future, please avoid committing your Rproj file. It contains your local project options which, if committed, overwrite the project options of other contributors.

Close #5.

antoine-sachet commented 4 years ago

Merged manually. Close #5.

Thanks again for your contribution!