Bugfix to as.data.frame.s3_bucket error when S3 object only contains Owner ID and not DisplayName (close #368)

vmarenny commented 4 years ago

Bugfixes

as.data.frame.s3_bucket correct logic that results in function error when [[Owner]][[ID]] is populated and [[Owner]][[DisplayName]] is not. In the case above map [[Owner]] to Owner_ID, and Owner_DisplayName to NA (#368).

Please ensure the following before submitting a PR:

[x] if suggesting code changes or improvements, open an issue first
[x] for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
[x] for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed

reisfe commented 1 year ago

@vmarenny, Any reason this was not merged? The problem seems to be still there.

vmarenny commented 1 year ago

@reisfe , the PR was open for a year and a half. This repo/package appears to be without a maintainer. There havent been any PRs merged since 2020

reisfe commented 1 year ago

That's a pity. Well, I will use your fix. Thanks.