search

cloudyr / ghit

Lightweight GitHub Package Installer
https://cloud.r-project.org/package=ghit
Other
43 stars 12 forks source link

Remove hard-coded "type" argument #19

Closed leeper closed 8 years ago

leeper commented 8 years ago

This should just default to getOption("pkgType")

https://github.com/cloudyr/ghit/blob/master/R/install.R#L76

But, need to check that it still works. This should resolve the issue of installing a package that has a dependency with compiled code (which should solve the complex installation issue raised here: https://github.com/cloudyr/aws.s3/issues/61).

leeper commented 8 years ago

repos should be passed to the repos argument rather than modified and passed as contriburl. https://github.com/cloudyr/ghit/blob/master/R/install.R#L77