search

cloudyr / googleCloudStorageR

Google Cloud Storage API to R
https://code.markedmondson.me/googleCloudStorageR
Other
104 stars 29 forks source link

Expose `predefinedAcl` in `gcs_save()` #172

Closed rvv23 closed 1 year ago

rvv23 commented 1 year ago

The gcs_upload() function uses the predefinedAcl argument to specify ACL for the file being uploaded. The gcs_save() function relies on the gcs_upload() function, but at the moment it does not allow specifying ACL for the file.



This means that gcs_save() can fail for buckets set to “uniform” access control. Of course, this issue may be circumvented by setting the bucket’s access control to “fine-grained”, or by saving locally and then using gcs_upload(), but exposing the predefinedAcl argument of the underlying gcs_upload() would be a neater solution.

MarkEdmondson1234 commented 1 year ago

Thanks, this was an oversight on my part not to include it here too