Please check if this makes snese

cloudyr / rmote

Utilities for running R on a remote server

MIT License

127 stars 19 forks source link

Please check if this makes snese #5

Closed snoweye closed 8 years ago

snoweye commented 8 years ago

avoid error when no device open except the default NULL device.
turn on rmote when start_rmote() is called.

codecov-io commented 8 years ago

Current coverage is 59.13%

Merging #5 into master will increase coverage by 40.40%

@@             master         #5   diff @@
==========================================
  Files             6          6          
  Lines           299        301     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits             56        178   +122   
+ Misses          243        123   -120   
  Partials          0          0

Powered by Codecov. Last updated by 439fa1b...6a5965a

snoweye commented 8 years ago

Do you have any chance to check the PR? I have already incorporated rmote into our package (see #https://github.com/RBigData/remoter/pull/16) and would like to see if the PR is possible.
Do you have any plan to send this package to CRAN? Thanks.

hafen commented 8 years ago

Sorry! Been traveling. This looks good.

I plan to release on CRAN but not until I replace the approach with something more friendly to base R (handling plot outputs with hooks rather than overriding plot print methods). I've started on this but don't think I'll have a chance to finish it up for a month or so.

snoweye commented 8 years ago

Great! Thanks for the merging.

You may try to overwrite options(devices = ..) that may be easier than hijacking the before.plot.new hook since sometimes more than one devices can open and switch. It should work for both base graphics and ggplot alike approach. FYI. #https://github.com/snoweye/remoter/blob/master/R/server.r#L77