cloudyspells / PsrAzDo-workbooks

Azure Monitor workbooks for Analyzing PSRule.Rules.AzureDevOps results

MIT License

6 stars 1 forks source link

Bug: Bicep Deployment Fails because it finds a duplicate vault in western europe with name 'kv-psrule-azdo-prd-weu' #5

Closed takis-kapas closed 9 months ago

takis-kapas commented 9 months ago

🐞 Bug Report

Describe the bug

Probably this happens because the Vault name defined in the Bicep template is static and the location is hard coded to western europe, where this vault already exists. Maybe add a random suffix in the vault's name?

Is this a regression?

To Reproduce

1. 2. 3. 4.

Expected behaviour

Media prove

Your environment

OS:
PowerShell version:
PSRule version:
PSRule.Rules.AzureDevOps version:

Additional context

webtonize commented 9 months ago

Fixed this by using a uniqueString as part of the resource name for Key Vault and Log Analytics workspace. Base for the uniquestring is the subscription and resourcegroup id.