search

cloutierjo / titleUrl

Firefox plugin that add the url in the title
GNU General Public License v3.0
15 stars 4 forks source link

activate options 'Save' button only if changes are made #7

Open schmittlauch opened 6 years ago

schmittlauch commented 6 years ago

this implements the small UX improvement I mentioned in #6.

The "Save" button is disabled by default and only enabled if the content of the textfield changed. Furthermore it provides feedback to the user that clicking the button did something by disabling it again after saving changes.

schmittlauch commented 6 years ago

One thing I noticed while testing my changes: Firefox 56 refused to (temporary) load the addon as a .zip file, to successfully load it I had to change the extension to .xpi. Is it supposed to be that way?

cloutierjo commented 6 years ago

I'm not sure about this one. The best would be to stay in line with the rest of Firefox. From what I see it should be an auto save on change. While I'm not a big fan of the save without confirmation, I haven't found a single save button in Firefox config. The closest thing I've found is the proxy setting which has ok/cancel buttons, but they are always enabled.

Do you have any other comparison element I could use to compare and stay close to the way it's working in Firefox?

schmittlauch commented 6 years ago

Do you have any other comparison element I could use to compare and stay close to the way it's working in Firefox?

Looking at the Firefox settings page, the behaviour seems to differ there: First of all, it looks like they wanted to avoid having text fields on the main settings pages at all - it's mostly checkboxes or buttons opening dialogues. The startpage text field seems to be saved immediately when being edited. But on the Firefox account settings page, the text field has to be activated first (with a button next to it) before you can change your device's name.

We could also change the settings page to save the separator string once the textbox looses fokus.

Azlond commented 6 years ago

Just as an explanation: I went with the save button after checking out the official documentation. Both Implement a settings page as well as Options page use the basic button.