search

clovaai / bros

Apache License 2.0
155 stars 23 forks source link

MLM Pretraining missing bbox inputs #13

Open darraghdog opened 2 years ago

darraghdog commented 2 years ago

Hi, Great work on the package. It seems on some of the model classes, eg. BrosLMHeadModel, the code misses the bbox inputs. Example below. Correct me if I misunderstood, but I guess bbox should be added here. If you would like I can put in a PR to fix it here and in the other places like BrosForSequenceClassification and BrosPreTrainedModel.

MLM Model input https://github.com/clovaai/bros/blob/eb3aa51ad7348444bafb06be64c4604182275edd/bros/modeling_bros.py#L1314-L1318 Bros Model call in MLM Model https://github.com/clovaai/bros/blob/eb3aa51ad7348444bafb06be64c4604182275edd/bros/modeling_bros.py#L1378-L1381

tghong commented 2 years ago

Hi, thank you for your interest in our work! You are right. Sorry for the confusion. (When implementing the code, I copied and pasted the modeling_bert.py of Hugging Face's transformers and modified only a part...) I'd appreciate if you could open the PR!

logan-markewich commented 1 year ago

I've opened a PR for this :)