search

clovaai / voxceleb_trainer

In defence of metric learning for speaker recognition
MIT License
1.03k stars 272 forks source link

SEBasicBlock operation order #57

Closed cirograciapons closed 3 years ago

cirograciapons commented 4 years ago

Hello , assuming SEBasicBlock wants to be an extended BasicBlock from typical Resnet Implementation (torchvision)

i dont understand why the order of the operations is different here : https://github.com/clovaai/voxceleb_trainer/blob/master/models/ResNetBlocks.py#L25 In torchvision basic block relu goes after batch norm. is this a bug or there is a special reason for this change?

thank you in advance

joonson commented 4 years ago

The order of BN and ReLU is always the subject of debate. I selected this order because it worked well on this task.