clovaai / voxceleb_trainer

In defence of metric learning for speaker recognition
MIT License
1.03k stars 272 forks source link

In eval phase, is it correct to use L2 distance even for Angular xx losses? #68

Closed w4-jonghoon closed 3 years ago

w4-jonghoon commented 3 years ago

https://github.com/clovaai/voxceleb_trainer/blob/6d3db45cbe00c27df71d6b04ca5fec0edc5317ac/SpeakerNet.py#L158

While training, you used cosine similarity as a distance metric for several loss objects, but in the evaluation, it seems you only used L2 distance (https://pytorch.org/cppdocs/api/function_namespacetorch_1_1nn_1_1functional_1a902d9a614b0a9e7a1073212da99ec5da.html) I think this may occur wrong calculation. Could you please review this problem?

joonson commented 3 years ago

See my comment to #4

w4-jonghoon commented 3 years ago

Thank you @joonson !