clovaai / wsolevaluation

Evaluating Weakly Supervised Object Localization Methods Right (CVPR 2020)
MIT License
332 stars 55 forks source link

Doubt regarding input image files in metatdata #32

Closed gowriaddepalli closed 4 years ago

gowriaddepalli commented 4 years ago

The code in the data loader reads the image_ids file as: which has.jpg appended

with open(metadata['image_ids' + suffix]) as f: for line in f.readlines(): image_ids.append(line.strip('\n'))

but while reading open Images data, and reading the localization.txt, it expects. path_file.jpg.npy. isnt it wrong? should it not be path_file.npy. The jpg should be dropped. It would be great if you could clear this issue.

coallaoh commented 4 years ago

Thanks for your observation, but I cannot find the specific code fragment you're referring to. Can you point to the lines via URLs? See https://docs.github.com/en/github/managing-your-work-on-github/creating-a-permanent-link-to-a-code-snippet

gowriaddepalli commented 4 years ago

https://github.com/clovaai/wsolevaluation/blob/e00842f8e9d86588d45f8e3e30c237abb364bba4/data_loaders.py#L62

junsukchoe commented 4 years ago

Thanks for your interest in our work!

Actually, the image_id includes .jpg. For example, the score map is located at {output_path}/image1.jpg.npy.

gowriaddepalli commented 4 years ago

yes, but as per documentation is was just {output_path}/image1.npy

Apart from that, if you do that, as well, i start getting KeyError: 'image.jpg' in this self.mask_paths[image_id],

https://github.com/clovaai/wsolevaluation/blob/e00842f8e9d86588d45f8e3e30c237abb364bba4/evaluation.py#L366

any suggestions why is it giving this error, when everything is done as per the metadata/localization.txt

gowriaddepalli commented 4 years ago

I managed to clear the above error. Thanks for your time.