search

clovaai / wsolevaluation

Evaluating Weakly Supervised Object Localization Methods Right (CVPR 2020)
MIT License
332 stars 55 forks source link

Regarding code logic for get mask (reading mask code) #33

Open gowriaddepalli opened 4 years ago

gowriaddepalli commented 4 years ago

https://github.com/clovaai/wsolevaluation/blob/e00842f8e9d86588d45f8e3e30c237abb364bba4/evaluation.py#L324

In this code, this is causing issue: TypeError: Expected Ptr for argument 'src' when there is a mask path but no ignore file.

Could you detail more on this.

junsukchoe commented 4 years ago

I cannot reproduce the error. Could you please give more information?

gowriaddepalli commented 4 years ago

Hi, to reproduce the error, you need to have no ignore files in your localization.txt in your metadata folder. just leave it blank. like the format below:

path to image, path to mask, path to ignore file.

just leave path to ignore file as empty. then you can reproduce the error.

I also wanted to know more in detail the what exactly are ignore files. It would be great if they could be explained a more in detail.

Also, how are the masks generated. like the specifications of the mask files

It would be great if you could detail, how can you make this code running on custom data set for object detection/ segmentation which has masks.

junsukchoe commented 4 years ago

Regarding the ignore masks (from our paper):

OpenImages has instance-wise masks, but not all of them are annotated as masks. When the objects are difficult to be annotated instance-wise or there are simply too many, the “group-of” box annotations are provided over the region containing multiple instances (e.g. hundreds of books on bookshelves in an image taken at a library – See Figure 11). We have indicated the regions with the “group-of” boxes as “ignore” regions, and have excluded them from the evaluation during the computation of PxPrec, PxRec, and PxAP.

But still I cannot reproduce your error. Many lines in our localization.txt also do not have path_to_ignore_file and error does not occur. Could you please show a bit of your localization.txt?

gowriaddepalli commented 4 years ago

hey my localization.txt just has two columns, none of the rows have any " path to ignore file".

path to image, path to mask,

Thats it.