search

cloverfield-tools / cf-package

Cloverfield Package Scaffold
MIT License
98 stars 14 forks source link

Handle environnement variables under windows fixes #13 #14

Closed forresst closed 9 years ago

ericelliott commented 9 years ago

@nkbt Take a look? =)

nkbt commented 9 years ago

Yes, will check later how it works on win/osx

ericelliott commented 9 years ago

@forresst Any progress on this?

forresst commented 9 years ago

Sorry, I'm very busy right now, I hope to do this week.

ericelliott commented 9 years ago

:+1:

forresst commented 9 years ago

@ericelliott @nkbt Done, sorry for the delay!

ericelliott commented 9 years ago

Hmm.. What's the best way to tell CircleCI to re-run this check?

nkbt commented 9 years ago

LGTM, @forresst please, rebase, that should fix the build.

nkbt commented 9 years ago

@ericelliott just manually click the button Rebuild. But it should fail, since PR is not rebased.

ericelliott commented 9 years ago

:+1:

forresst commented 9 years ago

Done ! @ericelliott @nkbt you must click Rebuild for this to work?

EDIT : It's ok (Mishandling)

nkbt commented 9 years ago

@forresst nah, it just rebuilds by any update automatically

forresst commented 9 years ago

It's good now ?