search

cloverfield-tools / cf-package

Cloverfield Package Scaffold
MIT License
98 stars 14 forks source link

[Issue #36] use pre-commit lib #37

Closed gblejman closed 8 years ago

gblejman commented 8 years ago

@nkbt @ericelliott

nkbt commented 8 years ago

How is it better?

I actually switched to husky quite recently. It supports any hooks. So I can do lint on pre-commit and full validate on pre-push.

Have a look at it, maybe you will like it better too

ericelliott commented 8 years ago

Husky sounds cool. Should we open another PR for that?

nkbt commented 8 years ago

I think this one is ok.

The only "problem" I found with husky is that it does not override existing hooks. That is not really a problem, but when I did migration from pre-commit to husky I had to manually cleanup hooks dir before install.

Oh, I just could add pre-install npm script I guess...

ericelliott commented 8 years ago

Cool, if you're happy, feel free to merge. I don't have time to look at it in detail. =)

gblejman commented 8 years ago

Thanks @nkbt I haven't used husky, seems good to also be able to split stages.. My initial concern was cleaning up those unused initial files created by pre-commit-hook

nkbt commented 8 years ago

Fancy giving it a shot?

gblejman commented 8 years ago

sure, i'll create a new PR for husky later today

nkbt commented 8 years ago

Closed in favor of #38