search

cloverfield-tools / cf-package

Cloverfield Package Scaffold
MIT License
98 stars 14 forks source link

[#36] Replace precommit-hook with husky for git hooks #38

Closed gblejman closed 8 years ago

gblejman commented 8 years ago

@nkbt

One thing i've noticed is that husky creates hooks with predefined names which match to npm scripts, i don't know if you are ok with this convention.

Also i don't know if the template it uses for hook generation is bulletproof regarding the PATH for future node version updates (ie: using nvm), check any hook it creates to see what i mean

nkbt commented 8 years ago

I guess you should also remove .jshint* from .gitignore and/or .npmignore

gblejman commented 8 years ago

done, yes i find the predefined hook names also to be better

ericelliott commented 8 years ago

What's the verdict? Do we like this better?

nkbt commented 8 years ago

:+1: from me

The only note: npm prune && rm -rf .git/hooks/* before npm update.

ericelliott commented 8 years ago

Feel free to merge. I am very busy right now, prepping for WebDirections next week.

nkbt commented 8 years ago

I tested locally, works fine.