cloverfield-tools / cf-package

Cloverfield Package Scaffold
MIT License
98 stars 14 forks source link

Upgrade to babel 6 #42

Closed bengarnett closed 8 years ago

bengarnett commented 8 years ago

Fixes https://github.com/cloverfield-tools/cf-package/issues/41

bengarnett commented 8 years ago

This does not yet update the template/ generated code to babel6 Will add this before merge

ericelliott commented 8 years ago
> cf-package@1.0.2 build /home/ubuntu/cf-package
> babel lib --out-dir build

Error: Couldn't find preset "es2015" relative to directory "/home/ubuntu/cf-package"
bengarnett commented 8 years ago

fixed that one, but now i'm seeing a npm run audit error with nsp in circle-CI, don't know how to fix it yet

bengarnett commented 8 years ago

looks like audit fails on master also

nkbt commented 8 years ago

Maybe node 0.10 is too old for all this? Switch to v4?

bengarnett commented 8 years ago

I'm on v4. updating nsp to v2 and it seems to work. another CI check incoming

nkbt commented 8 years ago

circleci uses node 0.10 for now

nkbt commented 8 years ago

\o/

bengarnett commented 8 years ago

oh, ic. it doens't look like node version was the issue. CircleCI is good now

bengarnett commented 8 years ago

note, that this fixes issue #41 and updates cf-package to babel 6. but the template is still on babel 5 @nkbt thanks.