search

cloverfield-tools / cf-package

Cloverfield Package Scaffold
MIT License
98 stars 14 forks source link

Convert template to babel 6 #43

Closed bengarnett closed 8 years ago

bengarnett commented 8 years ago

Tested this on node v4 only. nvm wasn't installing :/ and I'm not real familiar how babel handles multiple node versions. Since the object.assign plugin was used, I went ahead and added a test for it

bengarnett commented 8 years ago

since test pass on Circle, i guess this is good on node v 0.10

nkbt commented 8 years ago

Circle does not test template. Actually we need to make it testable too! Like do a fresh install and try to generate template.

I'll have a look how it works later and merge if all's good.

bengarnett commented 8 years ago

Ah. Good point. I did run tests in a generated project in node 4. would definitely appreciate you looking it over

nkbt commented 8 years ago

awww snap, I forgot the key from my laptop at work and will be able to look only tomorrow =(

nkbt commented 8 years ago

Looks good, works fine for me, thank you!