cloverfield-tools / universal-react-boilerplate

A simple boilerplate Node app.
MIT License
904 stars 97 forks source link

Implement React Render #23

Closed ericelliott closed 8 years ago

ericelliott commented 9 years ago

Implement a simple root route and render with react-engine

SOSANA commented 9 years ago

I will take this on :)

What about updating package.json file? include it in this task?

nkbt commented 9 years ago

@SOSANA I've just updated deps and tested, it is in #26 It is always better to do such things separately

SOSANA commented 9 years ago

@nkbt agreed.

ericelliott commented 9 years ago

@SOSANA @nkbt If I don't respond before you get to it, please feel free to merge each other's commits if you're confident about the change.

If anybody proposes tech changes (not just implementing the Roadmap), please wait for others to weigh in.

nkbt commented 9 years ago

OK

SOSANA commented 9 years ago

I want to do a PR for updated package.json that includes react-engine, reactjs, etc. Should I do this against the Universal branch or master branch?

SOSANA commented 9 years ago

@zebulonj let me know if you are going to take this on as per @ericelliott #13 suggestion

ericelliott commented 9 years ago

@SOSANA Master, please. =)

ericelliott commented 9 years ago

@SOSANA All yours. Have at it! =)

SOSANA commented 9 years ago

@ericelliott right on, I'll open a new issue for views/components that ties in with this PR. For now. Either myself or someone else can take it on. Excited!

zebulonj commented 9 years ago

I'd like to help with this. If someone else is taking lead, I'll contribute where it is needed.

ericelliott commented 9 years ago

Great.

@SOSANA Please see the "hello world" component in react-hello and make sure to read Baby's First Reaction.

I have a mission for you, @zebulonj ... You should probably also read Baby's First Reaction if you haven't, yet.

ericelliott commented 9 years ago

If you guys want to chat in realtime to touch bases, please use the JavaScript Questions chat. I'll try to monitor it at least a little bit every day and weigh in if you need guidance.

zebulonj commented 9 years ago

@ericelliot I've read it. I'll take a look at the mission you have for me when I'm at my computer.

ericelliott commented 9 years ago

:+1:

ericelliott commented 8 years ago

Beat you to it. See this commit.

Basically scrapped the whole thing and started over. I think best practices have evolved enough since we started this to justify it.