cloverfield-tools / universal-react-boilerplate

A simple boilerplate Node app.
MIT License
904 stars 97 forks source link

[#50] Migrate to ES6 #51

Closed vasco3 closed 8 years ago

ericelliott commented 8 years ago

Make sure npm run check works.

vasco3 commented 8 years ago

I'm getting the following error in bunyan after migrating to es6. I've seen that before, and it is fixed in the new bunyan version. So I submitted a PR for bunyan-request-logger https://github.com/ericelliott/bunyan-request-logger/pull/13

The error is


> universal-react-boilerplate@1.2.3 test /var/repositories/universal-react-boilerplate
> babel-node --ignore '/node_modules/(?!server|client|lib|healthcheck)' app/test/unit/index.js | tap-bail

/var/repositories/universal-react-boilerplate/node_modules/bunyan-request-logger/node_modules/bunyan/lib/bunyan.js:1348
module.exports.RotatingFileStream = RotatingFileStream;
                                    ^
ReferenceError: RotatingFileStream is not defined
    at Object.<anonymous> (/var/repositories/universal-react-boilerplate/node_modules/bunyan-request-logger/node_modules/bunyan/lib/bunyan.js:1429:37)
    at Module._compile (module.js:460:26)
    at normalLoader (/var/repositories/universal-react-boilerplate/node_modules/babel-core/lib/api/register/node.js:199:5)
    at Object.require.extensions.(anonymous function) [as .js] (/var/repositories/universal-react-boilerplate/node_modules/babel-core/lib/api/register/node.js:216:7)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/var/repositories/universal-react-boilerplate/node_modules/bunyan-request-logger/request-logger.js:5:12)
    at Module._compile (module.js:460:26)
vasco3 commented 8 years ago

Bunyan got fixed. But now babel-node is complaining about node-cuid.

> babel-node --ignore '/node_modules/(?!server|client|lib|healthcheck)' app/test/unit/index.js | tap-bail

/var/repositories/universal-react-boilerplate/node_modules/bunyan-request-logger/node_modules/cuid/dist/node-cuid.js:92
})(undefined.applitude || undefined);
            ^
TypeError: Cannot read property 'applitude' of undefined
    at Object.<anonymous> (/var/repositories/universal-react-boilerplate/node_modules/bunyan-request-logger/node_modules/cuid/dist/node-cuid.js:105:3)
    at Module._compile (module.js:460:26)
    at normalLoader (/var/repositories/universal-react-boilerplate/node_modules/babel-core/lib/api/register/node.js:199:5)
    at Object.require.extensions.(anonymous function) [as .js] (/var/repositories/universal-react-boilerplate/node_modules/babel-core/lib/api/register/node.js:216:7)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/var/repositories/universal-react-boilerplate/node_modules/bunyan-request-logger/request-logger.js:8:10)
    at Module._compile (module.js:460:26)
ericelliott commented 8 years ago

cuid is in a weird state right now. @therealklanni took a crack at modernizing it, but that broke it, so we rolled back, and I haven't had time to get it fixed. Would you like to take a look at that, too?

=)