cloverfield-tools / universal-react-boilerplate

A simple boilerplate Node app.
MIT License
904 stars 97 forks source link

[#76] Add end-to-end tests #78

Closed nkbt closed 8 years ago

nkbt commented 8 years ago

Fixes #76

20160127-215038
ericelliott commented 8 years ago

I usually put functional browser tests (aka e2e) in source/test/functional/browser. What do you think of that location?

nkbt commented 8 years ago

If we move e2e tests elsewhere then we need to create nightwatch.json pointing on that tests folder, just prefer to use nightwatch-autorun defaults to avoid extra configurations.

ericelliott commented 8 years ago

How much extra configuration are we talking about?

nkbt commented 8 years ago

Pretty much config from quickstart: https://github.com/nkbt/nightwatch-autorun/blob/master/nightwatch.json

ericelliott commented 8 years ago

So it's one option in a config file? Not sure that's such a bad thing. =)

nkbt commented 8 years ago

Moved tests, branch rebased

ericelliott commented 8 years ago

Seems to be working well. =) Thanks!