Format documents with leading `---`

clovyr / aeson-yaml

Encode any Aeson (JSON) value as YAML (in pure Haskell)

https://hackage.haskell.org/package/aeson-yaml

BSD 3-Clause "New" or "Revised" License

12 stars 7 forks source link

Format documents with leading `---` #6

Closed Gabriella439 closed 4 years ago

Gabriella439 commented 4 years ago

The context for this is: https://github.com/dhall-lang/dhall-haskell/issues/1864

Not only is this legal, but I believe it's actually more consistent with how --- was intended to be used (to separate each YAML document from its preceding header). The YAML specification also uses --- in the same way for its document-related examples.

patrickmn commented 4 years ago

Thanks for this, @Gabriel439. Looks good to me. foldMap is great.

Do you mind doing DCO with git commit --amend --signoff & git push --force prior to merging?

Gabriella439 commented 4 years ago

@patrickmn: Alright, I think I did it correctly, although I don't have permission to merge

patrickmn commented 4 years ago

All good. Added you as committer as well.

Will issue a new release today or tomorrow.

Gabriella439 commented 4 years ago

@patrickmn: Thank you! :slightly_smiling_face:

patrickmn commented 4 years ago

1.1.0.0 released (this is the only change)

Gabriella439 commented 4 years ago

@patrickmn: Awesome! Thanks 🙂