Code contracts are deprecated and should be replaced - Githubissues

clowd / Clowd.Squirrel

Quick and easy installer and automatic updates for cross-platform dotnet applications

427 stars 39 forks source link

Code contracts are deprecated and should be replaced #185

Closed KennyTK closed 8 months ago

KennyTK commented 10 months ago

Summary:

Code contracts have been deprecated and the project is dead.
Runtime code contracts do not work with VS2017/19.
Since NET 5+ and since Core 2.0 contracts are not supported.
Contract coverage is subpar and increasing coverage seems counterproductive given the current state.

What are code contracts? https://learn.microsoft.com/en-us/dotnet/framework/debug-trace-profile/code-contracts

Solutions:

Nullability supported since C# 7.0. Replace Contract.Requires(variable != null); with ArgumentNullException.ThrowIfNull
system.diagnostics.codeanalysis supported in NET core. Compatible with framework but feature essentially not available. Use Postconditions: MaybeNull and NotNull
Just remove them because they're clutter.

Further reading:

dotnet runtime 23869 stackexchange 47108 dotnet roslyn-analyzers 3134 nullable-analysis

caesay commented 8 months ago

I remove these and replace with throwing exceptions when I come across them.